Handle undefined modules when patching and raise UndefinedFunctionError#66
Open
xpgdk wants to merge 1 commit intoihumanable:masterfrom
Open
Conversation
Owner
|
I'm ok with raising an exception here, I'm not sure about UndefinedFunctionError though. Here's the reasons I'm less inclined to use UndefinedFunctionError:
This leaves us in a situation where the only time patch raises an UndefinedFunctionError is when the module is undefined and not when the function is undefined which also seems like weird behavior. I think it would make sense to do either of the following:
Are you interested in either of those alternatives? |
Author
|
I completely agree that I think adding a custom |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have noticed that trying to patch non-existing modules, results in an error, that may be quite difficult to understand.
The following code
will result in the following error
The first couple of times I saw this, I had absolutely no clue about what was going on. Only by looking into the
patchsource code, it became apparent, that I was doing something wrong.This PR adds a simple check that handles the
{:error, :nofile}case, and emits an error message that should be easier to understand: